Merged
Conversation
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
jlaur
reviewed
Jan 2, 2025
Contributor
jlaur
left a comment
jlaur
left a comment
There was a problem hiding this comment.
Thanks for the cleanup! Only some minor comments for consideration.
...ing.omnilink/src/main/java/org/openhab/binding/omnilink/internal/action/OmnilinkActions.java
Show resolved
Hide resolved
...k/src/main/java/org/openhab/binding/omnilink/internal/exceptions/BridgeOfflineException.java
Show resolved
Hide resolved
...ding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/ButtonHandler.java
Outdated
Show resolved
Hide resolved
...omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/AudioSourceHandler.java
Outdated
Show resolved
Hide resolved
...inding.omnilink/src/main/java/org/openhab/binding/omnilink/internal/handler/LockHandler.java
Outdated
Show resolved
Hide resolved
...ilink/src/main/java/org/openhab/binding/omnilink/internal/handler/OmnilinkBridgeHandler.java
Outdated
Show resolved
Hide resolved
...k/src/main/java/org/openhab/binding/omnilink/internal/handler/units/DimmableUnitHandler.java
Outdated
Show resolved
Hide resolved
...c/main/java/org/openhab/binding/omnilink/internal/handler/units/dimmable/UpbUnitHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
Signed-off-by: Ethan Dye <mrtops03@gmail.com>
DrRSatzteil
pushed a commit
to DrRSatzteil/openhab-addons
that referenced
this pull request
Jan 3, 2025
* Fix minor spelling errors * Reduce code complexity Signed-off-by: Ethan Dye <mrtops03@gmail.com>
chilobo
pushed a commit
to chilobo/openhab-addons
that referenced
this pull request
Feb 10, 2025
* Fix minor spelling errors * Reduce code complexity Signed-off-by: Ethan Dye <mrtops03@gmail.com> Signed-off-by: Christian Koch <78686276+chilobo@users.noreply.github.com>
phenix1990
pushed a commit
to phenix1990/openhab-addons
that referenced
this pull request
Jul 31, 2025
* Fix minor spelling errors * Reduce code complexity Signed-off-by: Ethan Dye <mrtops03@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some basic QOL improvements to the OmniLink code, also a few typo fixes as well.